Using the not equal operator for string comparison

I tried to check if the PHONE_TYPE variable contains one of three valid values.

if [ "$PHONE_TYPE" != "NORTEL" ] || [ "$PHONE_TYPE" != "NEC" ] ||
   [ "$PHONE_TYPE" != "CISCO" ]
    echo "Phone type must be nortel,cisco or nec"

The above code did not work for me, so I tried this instead:

if [ "$PHONE_TYPE" == "NORTEL" ] || [ "$PHONE_TYPE" == "NEC" ] ||
   [ "$PHONE_TYPE" == "CISCO" ]
    :        # do nothing
    echo "Phone type must be nortel,cisco or nec"

Are there cleaner ways for this type of task?

Asked By: munish


I guess you’re looking for:

if [ "$PHONE_TYPE" != "NORTEL" ] && [ "$PHONE_TYPE" != "NEC" ] &&
   [ "$PHONE_TYPE" != "CISCO" ]

The rules for these equivalents are called De Morgan’s laws and in your case meant:

not(A || B || C) => not(A) && not(B) && not (C)

Note the change in the boolean operator or and and.

Whereas you tried to do:

not(A || B || C) => not(A) || not(B) || not(C)

Which obviously doesn’t work.

Answered By: Nils Werner

You should use ANDs, not ORs.

if [ "$PHONE_TYPE" != "NORTEL" ] && [ "$PHONE_TYPE" != "NEC" ] && [ "$PHONE_TYPE" != "CISCO" ]


if [ "$PHONE_TYPE" != "NORTEL" -a "$PHONE_TYPE" != "NEC" -a "$PHONE_TYPE" != "CISCO" ]
Answered By: jlliagre

Good answers, and an invaluable lesson 😉 Only want to supplement with a note.

What type of test one choose to use is highly dependent on code, structure, surroundings etc.

An alternative could be to use a switch or case statement as in:

case "$PHONE_TYPE" in
    echo "OK"
    echo "Phone type must be nortel,cisco or nec"

As a second note you should be careful by using upper-case variable names. This is to prevent collision between variables introduced by the system, which almost always is all upper case. Thus $phone_type instead of $PHONE_TYPE.

Though that one is safe, if you have as habit using all upper case, one day you might say IFS="boo" and you’re in a world of hurt.

It will also make it easier to spot which is what.

Not a have to but a would strongly consider.

It is also presumably a good candidate for a function. This mostly makes the code easier to read and maintain. E.g.:

    case "$1" in
        return 0;;
        echo "Model $1 is not supported"
        return 1;;

if ! valid_phone_type "$phone_type"; then
    echo "Bye."
    exit 1
Answered By: Runium

A much shorter way would be:

if [[ ! $PHONE_TYPE =~ ^(NORTEL|NEC|CISCO)$ ]]; then 
  echo "Phone type must be nortel, cisco or nec."
  • ^ – To match a starting at the beginning of line
  • $ – To match end of the line
  • =~ – Bash’s built-in regular expression comparison operator
Answered By: 0x80

Use [[ instead

if [[ "$PHONE_TYPE" != "NORTEL" ]] || [[ "$PHONE_TYPE" != "NEC" ]] || 
   [[ "$PHONE_TYPE" != "CISCO" ]]
echo "Phone type must be nortel,cisco or nec"
exit 1
Answered By: Swapnil

To correct an above answer (as I can’t comment yet):

  echo "Phone type accepted."
  echo "Error! Phone type must be NORTEL, CISCO or NEC."

Please note that you need at least bash 4 for this use of =~
It doesn’t work in bash 3.

I tested on MS Windows 7 using bash 4.3.46 (works fine) and bash 3.1.17 (didn’t work)

The LHS of the =~ should be in quotes. Above, PHONE_TYPE=”SPACE TEL” would match too.

Answered By: Will

Just a variation proposal based on @0x80 solution:

# define phone brand list
phoneBrandList=" NORTEL NEC CISCO" ## separator is space with an extra space in first place

# test if user given phone is contained in the list
if [[ ${phoneBrandList} =~ (^|[[:space:]])"${userPhoneBrand}"($|[[:space:]]) ]]; then
    echo "found it !"
Answered By: tdaget

Less portable for POSIX, but works in Bash:

if [[ $PHONE_TYPE != @(NORTEL|NEC|CISCO) ]]; then 
    echo 'Phone type must be NORTEL, CISCO, or NEC' >&2
    exit 1
Answered By: Jesse Nickles
Categories: Answers Tags: ,
Answers are sorted by their score. The answer accepted by the question owner as the best is marked with
at the top-right corner.